Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make md5 logic centralised #5248

Merged
merged 2 commits into from Mar 14, 2024
Merged

make md5 logic centralised #5248

merged 2 commits into from Mar 14, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Mar 14, 2024 •
edited

Proposed changes

Allow similar code to be easily re-used via a variables.sh script.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner March 14, 2024 11:51
@pdabelf5 pdabelf5 merged commit 079a935 into main Mar 14, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the variable-script branch March 14, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pdabelf5 @oseoin @vepatel