Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dockerfile for CI #743

Merged
merged 1 commit into from Oct 29, 2019
Merged

Remove Dockerfile for CI #743

merged 1 commit into from Oct 29, 2019

Conversation

martialonline
Copy link
Contributor

Proposed changes

  • Remove Dockerfile for CI (no longer used)

Dean-Coakley
Dean-Coakley approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note for @Rulox :
This is now done in travisci instead:

kubernetes-ingress/.travis.yml

Lines 22 to 23 in 856d5de

- echo "Checking ingress controller for linting errors" && wget -O - -q ${golangci_lint} | sh -s v1.17.1
- export PATH="$PATH:./bin" && make lint

@martialonline martialonline merged commit 5afcb18 into master Oct 29, 2019
@martialonline martialonline deleted the remove-dockerfile-ci branch October 29, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martialonline @Rulox @Dean-Coakley