Move conformance tests to tests directory #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
lucacome
force-pushed
the
chore/conformance-tests
branch
14 times, most recently
from
6173fbd
to
04470a5
Compare
lucacome
force-pushed
the
chore/conformance-tests
branch
from
c246b1b
to
d0974eb
Compare
ciarams87
requested changes
May 16, 2024
There was a problem hiding this comment.
Looks good overall!
There's just a couple of developer docs that need to be updated as well:
https://github.com/nginxinc/nginx-gateway-fabric/blob/main/docs/developer/quickstart.md?plain=1#L198
https://github.com/nginxinc/nginx-gateway-fabric/blob/main/docs/developer/testing.md?plain=1#L106
|
Thanks for catching those @ciarams87 ! I have updated them. |
lucacome
force-pushed
the
chore/conformance-tests
branch
2 times, most recently
from
ffccea9
to
e7b69b8
Compare
sjberman
reviewed
May 17, 2024
lucacome
force-pushed
the
chore/conformance-tests
branch
from
1ed2846
to
ffbdb1d
Compare
lucacome
force-pushed
the
chore/conformance-tests
branch
from
7150136
to
1be1f59
Compare
|
https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/reports/v1.0.0/nginxinc-nginx-gateway-fabric will need its README updated (as well as when we introduce our next release that supports v1.1.0). |
lucacome
force-pushed
the
chore/conformance-tests
branch
from
b5ef0a0
to
400ae2e
Compare
sjberman
reviewed
May 20, 2024
lucacome
force-pushed
the
chore/conformance-tests
branch
from
4cbfd76
to
ba88062
Compare
lucacome
force-pushed
the
chore/conformance-tests
branch
from
ba88062
to
ecf4546
Compare
sjberman
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The conformance directory is outside of our tests directory containing all of our tests. This conformance directory has a separate Makefile with many duplicated commands and variables.
At release time we have to update all the versions in multiple places.
Solution: Move the conformance tests inside the tests directory and consolidate the Makefile so it's easier to maintain and update at release time
Closes #1977
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.