Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up generation #1990

Merged
merged 3 commits into from
May 20, 2024
Merged

Speed up generation #1990

merged 3 commits into from
May 20, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented May 17, 2024

Proposed changes

Problem: Generation is slow and throws a bunch of warnings.

Solution: Use go:generate once per package as suggested in https://github.com/maxbrunsfeld/counterfeiter#step-2b---add-counterfeitergenerate-directives

Testing: I removed all the generated files and they are re-generated correctly.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner May 17, 2024 19:49
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 17, 2024
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucacome lucacome merged commit 9212c4b into nginxinc:main May 20, 2024
40 checks passed
@sjberman sjberman mentioned this pull request May 20, 2024
6 tasks
@lucacome lucacome deleted the chore/generation branch May 21, 2024 01:13
@lucacome lucacome self-assigned this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants