Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more linters #733

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Add more linters #733

merged 2 commits into from
Jun 17, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jun 6, 2024

Proposed changes

Adds more linters and fixes errors

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING
    guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@lucacome lucacome self-assigned this Jun 6, 2024
@lucacome lucacome requested a review from a team as a code owner June 6, 2024 00:54
@github-actions github-actions bot added documentation Pull requests/issues for documentation chore Pull requests for routine tasks tests Pull requests that update tests labels Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 3.86%. Comparing base (a32ca97) to head (bd32a77).

Files Patch % Lines
exporter.go 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #733      +/-   ##
========================================
- Coverage   3.87%   3.86%   -0.01%     
========================================
  Files          5       5              
  Lines       1316    1319       +3     
========================================
  Hits          51      51              
- Misses      1265    1268       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome merged commit 2877168 into main Jun 17, 2024
15 checks passed
@lucacome lucacome deleted the chore/add-more-linters branch June 17, 2024 13:39
@lucacome lucacome removed tests Pull requests that update tests documentation Pull requests/issues for documentation labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants