This repository has been archived by the owner on May 24, 2023. It is now read-only.
Add progress bar for showing entire testing time and current status #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made the decision early on to include vendors on Git to ensure that everyone cloning the repository has access to the exact same modules 😄 |
alessfg
reviewed
Jun 29, 2020
rtapi.go
Outdated
| @@ -382,6 +395,15 @@ func createPDF(endpoints []endpointDetails, output string) { | |||
| os.Stdout.Write([]byte("PDF report generated successfully!\n")) | |||
| } | |||
|
|
|||
| func showProgressBar(sum int) { | |||
| os.Stdout.Write([]byte("Total " + strconv.Itoa(sum) + " seconds.\n")) | |||
There was a problem hiding this comment.
Can you tweak the Total: etc... output? I'm thinking of something along the lines of rtapi will take X seconds to run might sound a bit better?
|
I changed the message.(rtapi will take X seconds to run) ➜ rtapi git:(feature/show-progress-bar) ✗ ./build/darwin/rtapi -o ds.pdf -f data.json |
alessfg
approved these changes
Jun 30, 2020
|
Thanks! And thanks for your PR @urangurang! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function for show progress bar.
Please review when you have free time.
And one question.
Is directory vendor also needed to be tracked on git?
Thanks