Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define common data points #27

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Define common data points #27

merged 4 commits into from
Mar 5, 2024

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Feb 28, 2024 •
edited by shaun-nx
Loading

Proposed changes

Problem:
Ensure that our Kubernetes-related projects share common telemetry data points for consistency.

Solution:

  • Define common data points.
  • Generate Attributes() methods to allow using the type with the Exporter (to implement Exportable interface).

A project that uses the exporter library will also export the defined data type.

CLOSES -- #8

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING
    guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Feb 28, 2024
pleshakov
pleshakov commented Feb 28, 2024
View reviewed changes
pkg/telemetry/exporter.go Show resolved Hide resolved
pkg/telemetry/exporter.go Show resolved Hide resolved
pkg/telemetry/exporter.go Show resolved Hide resolved
pkg/telemetry/exporter.go Outdated Show resolved Hide resolved
pleshakov
pleshakov commented Feb 28, 2024
View reviewed changes
pkg/telemetry/exporter.go Outdated Show resolved Hide resolved
@pleshakov pleshakov marked this pull request as ready for review February 29, 2024 16:27
@pleshakov pleshakov requested a review from a team as a code owner February 29, 2024 16:27
@pleshakov
Define common data points
e852880 
Problem:
Ensure that our Kubernetes-related projects share common telemetry
data points for consistency.

Solution:
- Define common data points type.
- Generate Attributes() methods to allow using the type with the
Exporter (to implement Exportable interface).

A project that uses the exporter library will also export the
defined data type.

CLOSES - #8
@pleshakov
Copy link
Contributor Author

updated the PR

  • removed draft, marked as ready for review
  • rebased against main to properly generate Attributes methods
  • updated ClusterID doc string - mentioned about the UID of kube-system namespace

shaun-nx
shaun-nx reviewed Feb 29, 2024
View reviewed changes
pkg/telemetry/exporter.go Outdated Show resolved Hide resolved
@shaun-nx shaun-nx mentioned this pull request Mar 5, 2024
Merged
6 tasks
sjberman
sjberman reviewed Mar 5, 2024
View reviewed changes
pkg/telemetry/exporter.go Outdated Show resolved Hide resolved
@pleshakov @sjberman
Update pkg/telemetry/exporter.go
c70e763 
Co-authored-by: Saylor Berman <s.berman@f5.com>
@pleshakov pleshakov merged commit 6fef29d into main Mar 5, 2024
10 checks passed
@pleshakov pleshakov deleted the feature/common-data-points branch March 5, 2024 17:40
@pleshakov pleshakov mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pleshakov @sjberman @ciarams87 @shaun-nx