Skip to content

Commit

Permalink
platformtest.sh: Only show "runs=Y" when test suite succeeded
Browse files Browse the repository at this point in the history
Display "?" in the "runs" colum when the simple "run test" succeeded but
the test suite failed. And display a message to double check the actual
status, because it is somewhat unclear, if the daemon actually "works"
or not in this case.
  • Loading branch information
alexbarton committed Jan 10, 2016
1 parent 7cda2f1 commit 2254e92
Showing 1 changed file with 19 additions and 2 deletions.
21 changes: 19 additions & 2 deletions contrib/platformtest.sh
Expand Up @@ -189,7 +189,12 @@ fi
[ -n "$R_CONFIGURE" ] && C="Y" || C="N"
[ -n "$R_MAKE" ] && M="Y" || M="N"
[ -n "$R_CHECK" ] && T="$R_CHECK_Y" || T="N"
[ -n "$R_RUN" ] && R="Y" || R="N"
if [ -n "$R_RUN" ]; then
# Mark "runs" with "Y" only when the test suite succeeded:
[ "$T" = "N" ] && R="?" || R="Y"
else
R="N"
fi
[ -n "$COMMENT" ] && COMMENT=" $COMMENT"

echo
Expand All @@ -210,7 +215,19 @@ else
"$C" "$M" "$T" "$R" "$COMMENT"
fi
echo

double_check() {
echo "Please double check that the ngIRCd daemon starts up, runs and handles IRC"
echo "connections successfully!"
}

if [ "$R_CHECK_Y" = "y" ]; then
echo "$NAME: WARNING: Some tests have been skipped!"
echo "WARNING: Some tests have been skipped!"
double_check
echo
fi
if [ "$R" = "?" ]; then
echo "WARNING: The resulting binary passed simple tests, but the test suite failed!"
double_check
echo
fi

0 comments on commit 2254e92

Please sign in to comment.