Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated/managed Postgres support #13

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Integrated/managed Postgres support #13

merged 7 commits into from
Apr 7, 2021

Conversation

neersighted
Copy link
Collaborator

No description provided.

ngld
ngld requested changes Apr 6, 2021
View reviewed changes
packages/server/pkg/config/config.go Outdated Show resolved Hide resolved
tasks.star Outdated Show resolved Hide resolved
tasks.star Outdated Show resolved Hide resolved
@neersighted neersighted requested a review from ngld April 6, 2021 22:50
ngld
ngld approved these changes Apr 6, 2021
View reviewed changes
Copy link
Owner

@ngld ngld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Most of the %s placeholders should probably use the tuple notation (('cmd', arg, '-option', value_var)) instead to ensure proper escaping but it's probably fine since those values usually won't contain a quote.

tasks.star
],
outputs = ["build/nebula%s" % binext],
outputs = [str(neb_bin)],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ngld ngld merged commit 4c0a718 into ngld:nu Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngld ngld ngld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neersighted @ngld