Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added scroll for focusScroll in pymol mouse controls #992

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

chmnk
Copy link
Contributor

@chmnk chmnk commented Jun 27, 2023

Both scroll and drag-shift-right do focusScroll action in pymol, but scroll is more intuitive, because this makes controls mouse-only.

Both scroll and drag-shift-right do focusScroll in pymol, but scroll is more intuitive
@fredludlow
Copy link
Collaborator

I'm not familiar with pymol controls but this seems sensible. @ppillot ?

@papillot
Copy link
Contributor

papillot commented Jul 2, 2023

I don't use Pymol either. In the version I have, the mouse wheel seems to only move the front clipping pane. Zooming is done through right click or wheel + Ctrl + Shift
image
I agree that scroll to zoom seems more intuitive, but I am not sure it's the default specification for Pymol?

@chmnk
Copy link
Contributor Author

chmnk commented Jul 3, 2023

Zooming is done through right click or wheel + Ctrl + Shift

@papillot In your figure the editing mode is shown. I think the default pymol's mode is viewing, and the current pymol configuration in ngl seems to represent the viewing mode.

I agree that scroll to zoom seems more intuitive

No, I am not talking about zooming, I meant clipping. Zooming in pymol's viewing mode is the drag_right and that's nice and clean, and is already implemented in ngl.

In the version I have, the mouse wheel seems to only move the front clipping plane.

Following this reference https://pymol.org/dokuwiki/doku.php?id=mouse:clipping, in the viewing mode, scroll expands or shrinks the area between the clipping planes. That area is called "slab".
As it is better explained here https://pymol.sourceforge.net/newman/user/S0200start.html, shift+drag_right has more flexible behaviour that depends on the direction of dragging (up-down / left-right for moving front/back clipping planes instead of moving them as whole).

What I experienced in ngl with focusScroll reminded me the simple scroll action in pymol, which is the motivation of this request.

PS Actually when I started this, I didn't know the details of how does shift+drag_right work in pymol (I thought it's the same as scroll) :D

Copy link
Collaborator

@ppillot ppillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition

@ppillot ppillot merged commit cd8f528 into nglviewer:master Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants