Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix AOT instructions for global custom http parameter codec #15

Closed
wants to merge 1 commit into from

Conversation

mokipedia
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Current example in docs will not work with AOT: function call in decorator is not allowed

Issue Number: N/A

What is the new behavior?

using a object literal to circumvent constructor call

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@mokipedia mokipedia closed this Jun 15, 2020
@mokipedia
Copy link
Author

that approach also leads to problems, so closing this until a better solution is found

@mokipedia mokipedia reopened this Jun 15, 2020
@mokipedia mokipedia closed this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant