Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 New cashewConfig() to fix spread issue in forRoot() #24

Merged
merged 4 commits into from
Aug 19, 2020
Merged

fix: 🐛 New cashewConfig() to fix spread issue in forRoot() #24

merged 4 commits into from
Aug 19, 2020

Conversation

theblushingcrow
Copy link
Collaborator

@theblushingcrow theblushingcrow commented Aug 18, 2020 •
edited
Loading

✅ Closes: #23

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ x ] The commit message follows our guidelines: CONTRIBUTING.md#commit
  • [ x ] Tests for the changes have been added (for bug fixes / features)
  • [ x ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

In production environment no config is saved (neither default nor given).

Issue Number: 23

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

theblushingcrow added 2 commits August 18, 2020 10:02
fix: 🐛 New cashewConfig() to fix spread issue in forRoot()
e61306c 
BREAKING CHANGE: 🧨 configs passed to forRoot() cannot be partial (use cashewConfig to
prevent this)

✅ Closes: #23
refactor: 💡 added responseSerializer and parameterCodec
856cf45
@NetanelBasal NetanelBasal merged commit 7fca27f into master Aug 19, 2020
@NetanelBasal NetanelBasal deleted the fix/adding-cache-creator-method branch August 19, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetanelBasal NetanelBasal Awaiting requested review from NetanelBasal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default values config using forRoot works in Dev but not in Prod (Aot)
2 participants
@theblushingcrow @NetanelBasal