Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: angular 10 compatibility #29

Merged
merged 1 commit into from
Dec 28, 2020
Merged

fix: angular 10 compatibility #29

merged 1 commit into from
Dec 28, 2020

Conversation

Ledzz
Copy link
Contributor

@Ledzz Ledzz commented Dec 28, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There was an error when using module in newest angular: Generic type 'ModuleWithProviders' requires 1 type argument(s).

What is the new behavior?

The error is gone now.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@NetanelBasal NetanelBasal merged commit bcf1bab into ngneat:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants