Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 change requestDataChanged argument type #68

Merged
merged 2 commits into from
May 3, 2022

Conversation

ritox842
Copy link

@ritox842 ritox842 commented May 3, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

fix type of requestDataChanged first argument to support 'undefined'.
also, changed the names of the arguments to be more accurate.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

requestDataChanged accepts only HttpRequest

Issue Number: N/A

What is the new behavior?

requestDataChanged accepts HttpRequest | undefined

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

fix type of requestDataChanged first argument to support 'undefined'.
also, changed the arguments names to be more accureate.
fix type of requestDataChanged first argument to support 'undefined'.
@NetanelBasal NetanelBasal merged commit c31eff1 into ngneat:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants