Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure min-width and max-width sizes #103

Merged
merged 1 commit into from
May 28, 2023

Conversation

Tlepel
Copy link
Contributor

@Tlepel Tlepel commented May 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #102

What is the new behavior?

The modal configuration now supports setting the min-width and max-width css properties on modal sizes, just as the min-height and max-height work.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@stackblitz
Copy link

stackblitz bot commented May 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit 3e412ea into ngneat:master May 28, 2023
1 check passed
@Tlepel Tlepel deleted the min-max-width branch May 28, 2023 15:39
@Tlepel Tlepel linked an issue May 28, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set minWidth or maxWidth
2 participants