Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Food #56

Closed
NetanelBasal opened this issue Jan 17, 2022 · 2 comments · Fixed by #68
Closed

Food #56

NetanelBasal opened this issue Jan 17, 2022 · 2 comments · Fixed by #68
Assignees
@theryansmee
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@NetanelBasal
Copy link
Member

Description

Add food function

Proposed solution

No response

Alternatives considered

No response

Do you want to create a pull request?

No
@NetanelBasal NetanelBasal added enhancement New feature or request good first issue Good for newcomers labels Jan 17, 2022
@shaharkazaz
Copy link
Contributor

Maybe we should also have a food category (Italian, Chinese, etc)

@theryansmee
Copy link
Collaborator

@shaharkazaz - I really like this idea. I've got an idea for how this could work and could probably be used elsewhere where we will have large datasets 😊

theryansmee added a commit that referenced this issue Jan 18, 2022
@theryansmee
feat: 🔥 Add random food function
eb7bd71 
Add randFood function that takes a cuisine origin and returns a random
food from there

✅ Closes: #56
@theryansmee theryansmee mentioned this issue Jan 18, 2022
Merged
3 tasks
theryansmee added a commit that referenced this issue Jan 19, 2022
@theryansmee
refactor: 💡 Simplify food function implementation
3c3ae52 
✅ Closes: #56
theryansmee added a commit that referenced this issue Jan 19, 2022
@theryansmee
test: 🥳 Add tests for food
2337c07 
✅ Closes: #56
theryansmee added a commit that referenced this issue Jan 19, 2022
@theryansmee
feat: 🔥 Add missing foods from origins
d7d72b3 
Add last of foods to food.js. Clean up other files

✅ Closes: #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theryansmee theryansmee

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 🔥 Add random food from group ngneat/falso
3 participants
@NetanelBasal @theryansmee @shaharkazaz