feat: add precision to randNumber #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/falso/src/lib/float.ts
Outdated
| * @example | ||
| * | ||
| * randFloat({ min: 10, max: 20, fraction: 1 }) | ||
| * // 12.5 |
There was a problem hiding this comment.
Can you please run the docs and see that it looks OK with the comment?
There was a problem hiding this comment.
Looks good
Or would you rather have it one line?
There was a problem hiding this comment.
I meant in the live docs website :)
There was a problem hiding this comment.
Ahhh :)
I think it will look better if I have it on the same line, I'll change it
to be able to round numbers to closest 10, 100, 1000 you can set the precision of randNumber ngneat#226
leon
force-pushed
the
feat/randnumber-precision
branch
from
697340b
to
44fdcd6
Compare
NetanelBasal
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Cannot specify precision of randNumber
Issue Number: #226
What is the new behavior?
to be able to round numbers to closest 10, 100, 1000 you can set the precision of randNumber
Does this PR introduce a breaking change?
Other information
I hope it conforms to all the coding rules.
:)