Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gaylord company #296

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Remove gaylord company #296

merged 1 commit into from
Jul 14, 2022

Conversation

Hypenate
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

It removes a company that stood in a presentation.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I know it's a bit difficult, it's a real company it seems but still...
I understand if the PR gets rejected :)

@NetanelBasal
Copy link
Member

Sorry, I'm not sure what the issue is with this company? Can you elaborate, please?

@Hypenate
Copy link
Author

Yeah, like I stated, it's a dubious.
But seeing the word Gaylord in the mock/testdata is maybe unwanted for some.

@NetanelBasal NetanelBasal merged commit 7f0b3b3 into ngneat:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants