feat(toCollection): add a new generators to generate collection from … #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a generator function Generate a collection from a custom generators functions @category util @example toCollection(() => { return { data: randNumber(); } }) @example toCollection(() => { return { data: randNumber(); } }, { length: 10 }) // default is no length. It is a wrapper for the internal fake function. Fix ngneat#301
| const expectedData: fakeData = { data: 1 }; | ||
| randNumberSpy.mockReturnValueOnce(1).mockReturnValueOnce(2); | ||
| expect( | ||
| toCollection<fakeData, { length: number }>( |
There was a problem hiding this comment.
why do you need the explicitly define the generics in each call?
There was a problem hiding this comment.
Yes, you're right, it's just a habit, where in our project, we force type every time! And we forbid any. I will make the correction.
Fix PR review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a generator function
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Generate a collection from a custom generators functions
@category util
@example
toCollection(() => {
return { data: randNumber(); }
})
@example
toCollection(() => {
return { data: randNumber(); }
}, { length: 10 }) // default is no length.
It is a wrapper for the internal fake function.
What is the current behavior?
The fake function is internal and can Not bu used externaly.
Issue Number: #301
What is the new behavior?
Does this PR introduce a breaking change?