Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 more type enhancement using built-in keyword #325

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

okinawaa
Copy link
Contributor

I made objectKeys which can infer type strictly by behaving identical like Object.keys() function.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

In the original code, when data was added in json file, two file had to be modified, but through type inference, even if data is added, only one place(json file) needs to be modified. This increased the ease of maintenance.

Issue Number: N/A
reponed by #324 because of git issue😂

What is the new behavior?

same as before but increased the ease of maintenance.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I made objectKeys which can infer type strictly by behaving identical
like Object.keys() function
@stackblitz
Copy link

stackblitz bot commented Nov 18, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit f363bd1 into ngneat:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants