Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n-DE): city #338

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Conversation

kobenguyent
Copy link
Contributor

@kobenguyent kobenguyent commented Dec 22, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A
Resolve #issueNumber

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@stackblitz
Copy link

stackblitz bot commented Dec 22, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@kobenguyent
Copy link
Contributor Author

Summary of all failing tests
FAIL src/tests/json.spec.ts (7.215 s)
  ● randJSON › when it returns the expected values › should return an object with a random number of keys

    Max must be bigger than min

      51 | }: RandomInRangeOptions = {}) {
      52 |   if (max < min) {
    > 53 |     throw new Error('Max must be bigger than min');
         |           ^
      54 |   }
      55 |   return Number((random() * (max - min) + min).toFixed(fraction));
      56 | }

      at getRandomInRange (src/lib/core/core.ts:53:11)
      at src/lib/number.ts:62:33
      at fake (src/lib/core/core.ts:29:12)
      at randNumber (src/lib/number.ts:57:14)
      at Object.<anonymous> (src/tests/json.spec.ts:20:33)


Test Suites: 1 failed, 93 passed, 94 total
Tests:       1 failed, 418 passed, 419 total
Snapshots:   0 total
Time:        29.41 s
Ran all test suites.

failed with another test

@kobenguyent
Copy link
Contributor Author

image
looked good on local, perhaps rerunning tests would help.

@NetanelBasal
Copy link
Member

Screenshot 2022-12-22 at 14 27 10

@NetanelBasal
Copy link
Member

We should fix this spec

@kobenguyent
Copy link
Contributor Author

image
not sure what to do then, cause I didn't touch that spec, thou.

@NetanelBasal NetanelBasal merged commit 9feeb6d into ngneat:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants