Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🔥 add generators for browsers, priorities, brands and permission #83

Merged
merged 12 commits into from
Jan 20, 2022

Conversation

michaelxvoelker
Copy link
Contributor

@michaelxvoelker michaelxvoelker commented Jan 19, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Issue Number: #77 #78 #79 #80

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

This was referenced Jan 19, 2022
docs/docs/company.md Outdated Show resolved Hide resolved
packages/falso/src/lib/brand.json Show resolved Hide resolved
packages/falso/src/lib/browser.json Show resolved Hide resolved
packages/falso/src/lib/permission.ts Outdated Show resolved Hide resolved
packages/falso/src/lib/permission.json Show resolved Hide resolved
packages/falso/src/lib/permission.ts Outdated Show resolved Hide resolved
@NetanelBasal
Copy link
Member

@michaelxvoelker Thanks for your contributions! You're doing a great job.

@michaelxvoelker
Copy link
Contributor Author

@NetanelBasal You're welcome. 🙂 These are my first contributions to oss. 😅 Thank you very much for this welcoming and constructive environment. 🥇

@NetanelBasal
Copy link
Member

@michaelxvoelker please resolve the conflicts, and we can merge this.

@NetanelBasal NetanelBasal merged commit c8b1d62 into ngneat:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants