Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proxy method reset #24

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Added proxy method reset #24

merged 1 commit into from
Feb 22, 2021

Conversation

panic175
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There was no proxy for the reset method of an AbstractControl (like for patchValue and setValue).

What is the new behavior?

I added one

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I would have added a unit test for reset, if there would have been one for setValue (most likely only copy/paste), but I wasn't able to identify one :/

Added a proxy to the reset method of AbstractControl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants