Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(playground): add default query fn example #36

Merged
merged 1 commit into from
Oct 21, 2022
Merged

feat(playground): add default query fn example #36

merged 1 commit into from
Oct 21, 2022

Conversation

hrvbernardic
Copy link
Contributor

@hrvbernardic hrvbernardic commented Oct 20, 2022 •
edited by trungvose

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #31

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@stackblitz
Copy link

stackblitz bot commented Oct 20, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

NetanelBasal
NetanelBasal reviewed Oct 21, 2022
View reviewed changes
packages/playground/src/main.ts Outdated
@@ -35,6 +38,25 @@ bootstrapApplication(AppComponent, {
});
},
},
{
provide: QUERY_CLIENT_CONFIG,
deps: [HttpClient],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the deps and use inject inside useFactory

@NetanelBasal
Copy link
Member

Can you please pull from master?

@NetanelBasal
Copy link
Member

@hrvbernardic please fix the conflicts and pull master.

@NetanelBasal
Copy link
Member

@hrvbernardic, it only runs when you don't pass a queryFn right? the rest of the pages work fine.

@hrvbernardic
Copy link
Contributor Author

yeah I tried the others

@NetanelBasal NetanelBasal merged commit 7aac5ca into ngneat:main Oct 21, 2022
@NetanelBasal
Copy link
Member

Merged. What's next :)

@hrvbernardic
Copy link
Contributor Author

haha, Ill take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetanelBasal NetanelBasal NetanelBasal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hrvbernardic @NetanelBasal