Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using .setErrors doesn't trigger .errors$ to next() #45

Closed
Burgov opened this issue Sep 10, 2020 · 2 comments
Closed

using .setErrors doesn't trigger .errors$ to next() #45

Burgov opened this issue Sep 10, 2020 · 2 comments

Comments

@Burgov
Copy link
Contributor

Burgov commented Sep 10, 2020

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Setting an error to a control using .setErrors() does not trigger a new value to be emitted from .errors$.

Expected behavior

calling .setErrors() should trigger .errors$ to emit

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

We're calling .setErrors() based on a response from the API. Currently, this lib only checks for changes in errors directly after valueChanges, but since the API call is async, valueChanges is never triggered.

Environment


Angular version: 9.1.9


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@NetanelBasal
Copy link
Member

Do you want to create a PR?

@Burgov
Copy link
Contributor Author

Burgov commented Sep 15, 2020

@NetanelBasal #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants