Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure errors$ is nexted when setErrors is called manually #47

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

Burgov
Copy link
Contributor

@Burgov Burgov commented Sep 15, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #45

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Burgov
Copy link
Contributor Author

Burgov commented Sep 16, 2020

@NetanelBasal is any action from me required before this can be merged?

@NetanelBasal NetanelBasal merged commit fbeccc9 into ngneat:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants