fix(mock): make SpyObject properties writable by default

projects/spectator/jest/src/lib/mock.ts

@@ -1,7 +1,12 @@
 import { FactoryProvider } from '@angular/core';
 import { installProtoMethods, CompatibleSpy, SpyObject as BaseSpyObject, InjectableType } from '@ngneat/spectator';
 
-export type SpyObject<T> = BaseSpyObject<T> & { [P in keyof T]: T[P] & (T[P] extends (...args: any[]) => infer R ? jest.Mock<R> : T[P]) };
+type Writable<T> = { -readonly [P in keyof T]: T[P] };
+
+export type SpyObject<T> = BaseSpyObject<T> &
+  {
+    [P in keyof Writable<T>]: T[P] & (T[P] extends (...args: any[]) => infer R ? jest.Mock<R> : T[P]);
+  };
 
 /**
  * @internal

projects/spectator/jest/test/spy-object/spy-object.spec.ts

@@ -36,6 +36,8 @@ describe('SpyObject', () => {
 
     person.castToWritable().name = 'Other name'; // should compile
 
+    person.name = 'Other name'; // should also compile since 4.3.1
+
     expect(person.name).toBe('Other name');
   });
 });

projects/spectator/src/lib/mock.ts

@@ -30,10 +30,12 @@ export interface CompatibleSpy extends jasmine.Spy {
 /**
  * @publicApi
  */
-export type SpyObject<T> = T &
-  { [P in keyof T]: T[P] extends Function ? T[P] & CompatibleSpy : T[P] } & {
+export type SpyObject<T> = Writable<T> &
+  { [P in keyof Writable<T>]: T[P] extends Function ? T[P] & CompatibleSpy : T[P] } & {
     /**
      * Casts to type without readonly properties
+     *
+     * @deprecated Not needed anymore as since 4.3.1 all properties of SpyObject are already writable
      */
     castToWritable(): Writable<T>;
   };

projects/spectator/test/spy-object/spy-object.spec.ts

@@ -36,6 +36,8 @@ describe('SpyObject', () => {
 
     person.castToWritable().name = 'Other name'; // should compile
 
+    person.name = 'Other name'; // should also compile since 4.3.1
+
     expect(person.name).toBe('Other name');
   });
 });