Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spectator): add selectOption api and helper #202 #212

Merged
merged 5 commits into from
Oct 21, 2019

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 20, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

no selectOption
Issue Number: #202

What is the new behavior?

add selectOption

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Add `selectOption` helper which supports multi select dropdowns

ngneat#202
Add optional parameter to prevent dispatch of events
Change `emitEvents` argument to a config object argument.
@Coly010 Coly010 changed the title Feature/add select option feat(spectator): add selectOption api and helper #202 Oct 20, 2019
@NetanelBasal NetanelBasal merged commit b58e4c9 into ngneat:master Oct 21, 2019
@NetanelBasal
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants