feat(dom-spectator): add query with root opt for Type selector #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using
spectator.query()
, you can use{ root: true }
in order to query an element inside an overlay. But what if you want to query aSomeModalContentComponent
inside an overlay ?You cannot do
spectator.query(SomeModalContentComponent, { root: true })
.Issue Number: 0
What is the new behavior?
You can now query for components in a global way with
spectator.query(SomeModalContentComponent, { root: true })
.Does this PR introduce a breaking change?
Other information