Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dom-spectator): add query with root opt for Type selector #580

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

GuillaumeNury
Copy link
Contributor

@GuillaumeNury GuillaumeNury commented Sep 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When using spectator.query(), you can use { root: true } in order to query an element inside an overlay. But what if you want to query a SomeModalContentComponent inside an overlay ?

You cannot do spectator.query(SomeModalContentComponent, { root: true }).

Issue Number: 0

What is the new behavior?

You can now query for components in a global way with spectator.query(SomeModalContentComponent, { root: true }).

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@NetanelBasal
Copy link
Member

please add tests.

@GuillaumeNury
Copy link
Contributor Author

@NetanelBasal is it enough ? I am not sure whether or not I should create a new test file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants