feat(Router): Import RouterTestingModule when stubs are enabled

[AnthonyLenglet]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngneat/spectator/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #487

What is the new behavior?

createRoutingFactory now imports RouterTestingModule when stubs are enabled, then adds the necessary stubs and overrides, thus adding the missing inputs and methods from router related features

Does this PR introduce a breaking change?

[ ] Yes
[x] No

createRoutingFactory had an undocumented mockRouterLink that has been removed as it is no longer needed

Other information

[NetanelBasal]

Thanks for the PR. Now that I'm thinking about it, I can't remember why we have a stub here. Can you try to use the original directive, please?

[AnthonyLenglet]

from what I can gather, it looks like I can't just do moduleMetadata.declarations.push(RouterLink); instead of moduleMetadata.declarations.push(RouterLinkStub);

since angular 9, you need to import the module of the library directly
angular/angular#37047 (comment)

so turns out I need to import RouterTestingModule along with the other stubs when they are enabled

I was able to make it work but I needed to mock the serializeUrl function in the routerStub, as angular was trying to parse the url using it internally

serializeUrl(): string {
  return '/';
},

[AnthonyLenglet]

I'm actually not sure if the routerStub is still needed since I'm now importing RouterTestingModule, it looks like it should really just stub ActiveRoute

[NetanelBasal]

@AnthonyLenglet can you summarize the change, plesae?

[AnthonyLenglet]

Just updated the initial PR post with a new summary

createRoutingFactory now imports RouterTestingModule when stubs are enabled, then adds the necessary stubs and overrides, thus adding the missing inputs and methods from router related features

[NetanelBasal]

@AnthonyLenglet tests are failing.

[AnthonyLenglet]

oh right, I removed those from the jasmine tests, but forgot to remove them from jest, sorry about that !