-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🤖 upgrade to angular v15 #642
Conversation
|
Any update on this PR ? I am waiting for Angular 15 upgrade as well |
@manianna I'm not sure how this pr affects you as a user since this is only for the internal tooling and the playground app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🚀
Did you happen to test all the build/tests/linked the packages?
@@ -25,5 +25,5 @@ export interface SchemaOptions extends Schema { | |||
/** | |||
* The root project name. | |||
*/ | |||
project?: string; | |||
project: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you make this change? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nx run transloco-schematics:build
command failed because of this inconsistency.
I ran these tests locally and manually checked npm run ci:test -- --skipNxCache
npm run ci:build -- --skipNxCache
npm run ci:lint -- --skipNxCache
npm run ci:e2e -- --skipNxCache
npm run lint
npm run e2e Let me know if I forgot something. |
- npx nx migrate @nrwl/angular@15 - npx nx migrate @ngneat/spectator@12.2.1 - update jest v28 - update postcss BREAKING CHANGE: 🧨 Angular 14
BREAKING CHANGE: 🧨 Angular 15 - npx nx migrate @nrwl/angular@15.9.2 - npx nx migrate @nrwl/jest@15.9.2 - npx nx migrate @ngneat/spectator@14.0.0 - npx nx migrate nx@15.9.2
Any news on this PR? |
fixed merged conflicts and upgraded to angular v16 in new PR #661 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information