Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 upgrade to angular v15 #642

Closed
wants to merge 3 commits into from
Closed

chore: 🤖 upgrade to angular v15 #642

wants to merge 3 commits into from

Conversation

chimurai
Copy link
Contributor

@chimurai chimurai commented Apr 2, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Update Angular to v15
  • Update nx to v15.9.2

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@stackblitz
Copy link

stackblitz bot commented Apr 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@manianna
Copy link

Any update on this PR ? I am waiting for Angular 15 upgrade as well

@shaharkazaz
Copy link
Collaborator

@manianna I'm not sure how this pr affects you as a user since this is only for the internal tooling and the playground app.

Copy link
Collaborator

@shaharkazaz shaharkazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🚀
Did you happen to test all the build/tests/linked the packages?

@@ -25,5 +25,5 @@ export interface SchemaOptions extends Schema {
/**
* The root project name.
*/
project?: string;
project: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you make this change? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New NX version is stricter. Getting this error when I leave project as optional:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nx run transloco-schematics:build command failed because of this inconsistency.

@chimurai
Copy link
Contributor Author

Thanks for the PR! 🚀 Did you happen to test all the build/tests/linked the packages?

I ran these tests locally and manually checked npm run start:

npm run ci:test -- --skipNxCache
npm run ci:build -- --skipNxCache
npm run ci:lint -- --skipNxCache
npm run ci:e2e -- --skipNxCache
npm run lint
npm run e2e

Let me know if I forgot something.

- npx nx migrate @nrwl/angular@15
- npx nx migrate @ngneat/spectator@12.2.1
- update jest v28
- update postcss

BREAKING CHANGE: 🧨 Angular 14
BREAKING CHANGE: 🧨 Angular 15

- npx nx migrate @nrwl/angular@15.9.2
- npx nx migrate @nrwl/jest@15.9.2
- npx nx migrate @ngneat/spectator@14.0.0
- npx nx migrate nx@15.9.2
@krechtern
Copy link

Any news on this PR?

@chimurai chimurai mentioned this pull request Jun 3, 2023
3 tasks
@chimurai
Copy link
Contributor Author

chimurai commented Jun 3, 2023

fixed merged conflicts and upgraded to angular v16 in new PR #661

@chimurai chimurai closed this Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants