We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The untilDestroyed function seems to use the global variable ngDevMode to specify whether it should add a bit of extra debug information.
The implementation of this assumes that ngDevMode is defined, and is either truthy or falsy. However, according to Angular's implementation, it can actually be truthy, falsy or undefined: https://github.com/angular/angular/blob/main/packages/core/src/util/ng_dev_mode.ts#L24
In some specific setups of Angular applications, this means that any component using the untilDestroyed method can't be instantiated.
Suggest doing a more resilient check, like Angular do themselves: https://github.com/angular/angular/blob/main/packages/core/src/util/ng_dev_mode.ts#L118
Or simply relying on angular's own isDevMode() method, which does the same thing.
The text was updated successfully, but these errors were encountered:
Fixed in 9.2.3.
Sorry, something went wrong.
Impressive turn-around, thanks a lot!
No branches or pull requests
The untilDestroyed function seems to use the global variable ngDevMode to specify whether it should add a bit of extra debug information.
The implementation of this assumes that ngDevMode is defined, and is either truthy or falsy. However, according to Angular's implementation, it can actually be truthy, falsy or undefined:
https://github.com/angular/angular/blob/main/packages/core/src/util/ng_dev_mode.ts#L24
In some specific setups of Angular applications, this means that any component using the untilDestroyed method can't be instantiated.
Suggest doing a more resilient check, like Angular do themselves:
https://github.com/angular/angular/blob/main/packages/core/src/util/ng_dev_mode.ts#L118
Or simply relying on angular's own isDevMode() method, which does the same thing.
The text was updated successfully, but these errors were encountered: