Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code behind button and faster modal loading #144

Merged
merged 2 commits into from
Jan 29, 2022
Merged

QR code behind button and faster modal loading #144

merged 2 commits into from
Jan 29, 2022

Conversation

LukeLambert
Copy link
Contributor

I think placing the QR codes behind a button is important for a few reasons:

  • They contain private keys, so there are security implications for having them always visible.
  • When multiple codes are displayed on a page at once, it's easy to scan the wrong one.
  • At certain screen sizes, they broke the layout and appeared distorted.

I also made it so that content for the modal begins loading sooner (when the button is clicked rather than once the modal has finished animating).

@ngoduykhanh
Copy link
Owner

Thanks @LukeLambert , this change makes sense to me.
If we remove showing the QR by default, there are more spaces in the panels. I will have follow-up PRs to make the UI looks better.

@ngoduykhanh ngoduykhanh merged commit da99259 into ngoduykhanh:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants