Implement Optional Private Keys

[ferrine]

Address #160

• creation form update

• validate public key

• validate preshared key

• check QR code creation, disable QR if no private key

• check public key duplication

• make the additional fields hidden by default

[ferrine]

Step 1: Implement Public / Preshared keys manual input and validation

If can't be read with parseKey

[ferrine]

Ready for review

[SomeoneSerge]

Private keys seem to be a part of the persisted state, but I cannot see how their presence reflects in GUI, or how are they ever accessed for anything after the user has been set up.

• Is there still any need for storing the private key at all?
• When the private key is persisted, consider making this explicit for the user: maybe a red "Forget private key" button

[ferrine]

Private keys seem to be a part of the persisted state, but I cannot see how their presence reflects in GUI, or how are they ever accessed for anything after the user has been set up.

• Is there still any need for storing the private key at all?
• When the private key is persisted, consider making this explicit for the user: maybe a red "Forget private key" button

• Private key is used to include in email config
• Not storing private key at all means we can't send client config (if he doesn't share public key first)
• Like the idea to add a button, but not as a part of this PR

[SomeoneSerge]

Like the idea to add a button, but not as a part of this PR

With this PR, the private key becomes Maybe String rather than String. This rather should reflect in the GUI

Private key is used to include in email config

Oh

[ferrine]

@ngoduykhanh can you please have a look?

[ngoduykhanh]

@ferrine thank you for your contribution. The code changes look good to me but I have a few concerns/comments:

• What is the purpose of this feature? Is it for importing the existing WG config? If so, how do we manage the private key? We need it to generate a proper QR code/config file.
• I see you use ParseKey to validate the public keys and preshared keys. How about validating the duplication? We should not allow importing a public key that already exists.
• [UI] Since the Public Key and Preshared Key are optional, I think we should adjust the form to hide them by default (using Collapse for example) because it is a bit long now.

[ferrine]

What is the purpose of this feature? Is it for importing the existing WG config?

The user does not want to reveal his private key

If so, how do we manage the private key?

User manages his private key

We need it to generate a proper QR code/config file.

No QR can be generated

How about validating the duplication?

Did not think about this. Seems to be important but treated as a corner case.

[UI] Since the Public Key and Preshared Key are optional, I think we should adjust the form to hide them by default (using Collapse for example) because it is a bit long now.

Yes, I can try to make that more pretty

TODOs:

• check QR code creation, raise an error if private key is missing
• check public key duplication
• make the additional fields hidden by default

[ferrine]

@ngoduykhanh
The only feature I decided not to implement is

check QR code creation, raise an error if the private key is missing

It still generates the QR code but the config is incomplete (it was supposed to be so). Incomplete config is an expected behavior so I treat this as a feature.

UPD: I checked to import the no private key config. It raises an error in the wireguard app. So I'll remove QR code in this case

[ferrine]

This is a simple way to tell there is no QR

[ferrine]

an updated version disables Scan button

[ngoduykhanh]

Thanks @ferrine for addressing the issues. I have one more comment below. Other changes look good.

[ferrine]

Done