Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic error and make some settings optional in wg.conf template. #506

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

nanhantianyi
Copy link
Contributor

@nanhantianyi nanhantianyi commented Dec 27, 2023

Fix logic error and make some settings optional in wg.conf template.

@ngoduykhanh
Copy link
Owner

Hey @nanhantianyi thanks for the PR. Could you please make your PR description more informative to speed up my PR review process? Which was the issue and why do we need some sitting optional in the config file template?
Please also always add an empty line at the end of the file. Thank you!

@nanhantianyi
Copy link
Contributor Author

Hi @ngoduykhanh ,there is an {{end}} tag in wrong place which make the "Endpoint" config out of the range of ".Client.Enabled".
Make “PostUp”、”PreDown“、”PostDown“、”Table“ optional to ensure there is no empty config in generated file if user don't set them.

Copy link
Owner

@ngoduykhanh ngoduykhanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your clarification. It is a nice catch. I left 2 comments in your PR.

templates/wg.conf Outdated Show resolved Hide resolved
templates/wg.conf Outdated Show resolved Hide resolved
@ngoduykhanh ngoduykhanh merged commit 867aa13 into ngoduykhanh:master Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants