Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove console logs from the website #854

Closed
3 tasks done
Avinash905 opened this issue Jun 15, 2023 · 4 comments · Fixed by #913
Closed
3 tasks done

[BUG] Remove console logs from the website #854

Avinash905 opened this issue Jun 15, 2023 · 4 comments · Fixed by #913
Assignees
@Avinash905
Labels
🐞 bug This is a patch, generally fixing some bugs. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@Avinash905
Copy link
Contributor

Avinash905 commented Jun 15, 2023 •
edited
Loading

Description

There are console.logs present in the project which is displaying sensitive information like passwords on the browser console.
It is necessary to remove the console logs form the website to keep the data safe.

Screenshots

Screenshot (494)

Browser 🥦

Google Chrome

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (blank for no)
@Avinash905 Avinash905 added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Jun 15, 2023
@Avinash905
Copy link
Contributor Author

Please assign me this issue so that I can work on this issue under GSSOC'23.

@github-actions
Copy link

Hello, @Avinash905, thank you for opening an issue.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource 🚀

@tamalCodes
Copy link
Member

Hi , currently you have #855 and #856 assigned, please complete those and then we can start to work on this.

@ngoworldcommunity ngoworldcommunity locked and limited conversation to collaborators Jun 15, 2023
@tamalCodes tamalCodes added status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. and removed 🐞 bug This is a patch, generally fixing some bugs. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 15, 2023
@tamalCodes
Copy link
Member

You can start working on this.

Remember, Good PR makes a Good Developer !

We at Milan work hard to maintain the structure, and use conventional Pull request titles and commits.
Please make sure that you have read our documentation on Commiting guidelines and Pull request guidelines.

Without a proper template for the PR, not following the guidelines and spam might get the pull request closed, or banned.

@ngoworldcommunity ngoworldcommunity unlocked this conversation Jun 28, 2023
@tamalCodes tamalCodes added 🐞 bug This is a patch, generally fixing some bugs. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 and removed status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. labels Jun 28, 2023
@Avinash905 Avinash905 mentioned this issue Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Avinash905 Avinash905

Labels
🐞 bug This is a patch, generally fixing some bugs. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: console log removed Avinash905/Milan
2 participants
@Avinash905 @tamalCodes