Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer elements not centered #1076

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Conversation

Utkarsh3128
Copy link
Contributor

closes #1072

👷🏻 Changes made

comment out the css style of class join-us-list

📸 Screenshots

Before

after

After

Screenshot (228)

@github-actions github-actions bot added 🐞 bug This is a patch, generally fixing some bugs. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Sep 18, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Utkarsh3128, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Sep 24, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes that have been made however, I would love to have some more minor fixes if you are willing to.

  • Can you please remove the Contact Us from the footer
  • And replace the text for the report from:
    • GOT SOMETHING TO REPORT ? -> TALK TO US
    • You can submit a report to us by filling the form below ! -> Ideas, problems, violations ? Reach out to us !
    • Finally the button can be changed from Report to Contact Us

@tamalCodes tamalCodes added area/ui This issue is related to frontend/interface fix. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Sep 25, 2023
@Utkarsh3128
Copy link
Contributor Author

Sure, Sir I would love to work on this.

@Utkarsh3128
Copy link
Contributor Author

@tamalCodes Sir, I have made changes as per your request.

@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 2d8bf5d
✅ Preview: https://milan-acdwh98an-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/2EYz4kJxdo3oyjDyDDm3FWSDME6B

View Workflow Logs

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🎉

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource 🚀.

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. and removed status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Sep 25, 2023
@tamalCodes tamalCodes merged commit 2689c50 into ngoworldcommunity:main Sep 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui This issue is related to frontend/interface fix. 🐞 bug This is a patch, generally fixing some bugs. deployed This PR has been deployed to Vercel for testing. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
Status: Merged/Discarded
Development

Successfully merging this pull request may close these issues.

[BUG] Footer elements not centered on screens <768 pixels
2 participants