Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added website field to club registration and details page #1085

Merged

Conversation

stoyanov-kaloyan
Copy link
Contributor

closes #1078

👷🏻 Changes made

Added a field to input an email when registering a club. Added the website to the POST request so it will be functional when the backend gets updated accordingly. Added a link to the website on the clubs details page which is only visible when it exists.

📸 Screenshots

Screenshot 2023-09-26 at 21 19 49
Screenshot 2023-09-26 at 21 20 18

@github-actions github-actions bot added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 💡 feature This generally contains addition/changes to features. labels Sep 26, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @stoyanov-kaloyan, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot temporarily deployed to Preview September 26, 2023 18:24 Inactive
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: f5c62c7
✅ Preview: https://milan-3u9b1yxn0-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/DgvwuwgMVPx9auwrjU7fRQ3jsMaU

View Workflow Logs

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Sep 26, 2023
@stoyanov-kaloyan stoyanov-kaloyan marked this pull request as ready for review September 26, 2023 18:25
@tamalCodes tamalCodes added area/logic This issue is related to a logic fix. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Sep 26, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🎉

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource 🚀.

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. and removed status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Sep 26, 2023
@tamalCodes tamalCodes merged commit 7fde715 into ngoworldcommunity:main Sep 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. deployed This PR has been deployed to Vercel for testing. 💡 feature This generally contains addition/changes to features. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
Status: Merged/Discarded
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add and Configure the website field
2 participants