-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove number circles from homepage #1137
fix: remove number circles from homepage #1137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @varundhand, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
@tamalCodes ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work 🎉
The changes look good to me and will be merged soon.
Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !
Happy Opensource 🚀.
Thanks @tamalCodes ! I look forward to contribute more to the project😇 |
This pull request has been deployed to Vercel.
|
👷🏻 Changes made
I have removed the number circles from all sections of the website to create a cleaner and more streamlined design.
📸 Screenshots
before:
![Screenshot 2023-10-17 at 9 04 24 PM](https://private-user-images.githubusercontent.com/110025628/275891985-62e63db0-49a7-44f5-9dcb-4618251fc52c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0ODc1NzgsIm5iZiI6MTcxOTQ4NzI3OCwicGF0aCI6Ii8xMTAwMjU2MjgvMjc1ODkxOTg1LTYyZTYzZGIwLTQ5YTctNDRmNS05ZGNiLTQ2MTgyNTFmYzUyYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyN1QxMTIxMThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xZmQ5Mjg3MzNkZDExZWQzYTA0MTNkMTE2OTVjY2RiZTM0M2RhM2YzMGFhODY2MDBhMTUzZjdiZWU3YjIzZTI3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.rOFag9mozmv4uNuAG56PaKqSaIkcG9q5DzNpYTbUu6A)
after:
![Screenshot 2023-10-17 at 8 59 46 PM](https://private-user-images.githubusercontent.com/110025628/275890083-b60f942a-d88f-4eaf-8dd3-3420a40c3324.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0ODc1NzgsIm5iZiI6MTcxOTQ4NzI3OCwicGF0aCI6Ii8xMTAwMjU2MjgvMjc1ODkwMDgzLWI2MGY5NDJhLWQ4OGYtNGVhZi04ZGQzLTM0MjBhNDBjMzMyNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyN1QxMTIxMThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YmY4YWVmYTcyMTA0MWMyN2Q3MzY5ZjZlNmQ5NTRhNzJjZjE4ZDdhNDdkMTMwZTkyMzIwYjU2YmVhZGExMTYwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.m_ihfYXy10L-zmY5hUrWa98ir39ywlNucYRSPoJ4zJw)
Note to Reviewer
Kindly, label it as
hacktoberfest
andhacktoberfest-accepted
. Thanks!