Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove number circles from homepage #1137

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

varundhand
Copy link
Contributor

@varundhand varundhand commented Oct 17, 2023

👷🏻 Changes made

I have removed the number circles from all sections of the website to create a cleaner and more streamlined design.

📸 Screenshots

before:
Screenshot 2023-10-17 at 9 04 24 PM

after:
Screenshot 2023-10-17 at 8 59 46 PM

Note to Reviewer

Kindly, label it as hacktoberfest and hacktoberfest-accepted. Thanks!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @varundhand, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot temporarily deployed to Preview October 17, 2023 15:30 Inactive
@varundhand
Copy link
Contributor Author

@tamalCodes ready for review

@tamalCodes tamalCodes changed the title style: remove number circles fix: remove number circles from homepage Oct 17, 2023
@tamalCodes tamalCodes added 🐞 bug This is a patch, generally fixing some bugs. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. hacktoberfest-accepted This PR is accepted for Hacktoberfest. labels Oct 17, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🎉

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource 🚀.

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. and removed status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Oct 17, 2023
@varundhand
Copy link
Contributor Author

Thanks @tamalCodes ! I look forward to contribute more to the project😇

@tamalCodes tamalCodes merged commit 4dc733e into ngoworldcommunity:main Oct 19, 2023
3 checks passed
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 78ba8a5
✅ Preview: https://milan-pbqh7xhxm-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/GupCnaQehvZXJ7umxEfecHqQYRn1

View Workflow Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
Status: Merged/Discarded
Development

Successfully merging this pull request may close these issues.

None yet

2 participants