Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed functioning of contact us button in footer #1140

Merged
merged 6 commits into from
Oct 26, 2023

Conversation

MahendraDani
Copy link
Contributor

@MahendraDani MahendraDani commented Oct 18, 2023

closes #1131
closes #1141

👷🏻 Changes made

  1. Fixed the modal component. Modal component can now have dynamic children as per the need.
  2. On clicking the contact us button , a modal opens where user can report a problem. The Endpoint is /user/report.

📸 Screenshots

milan_fix_1131.mp4

The above recording shows three things-

  1. Proper functioning of contact us button and modal both.
  2. Sucessfull API call to report problem route.
  3. Proper functioning of database, where the report is stored as expected.

@github-actions github-actions bot added hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Oct 18, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MahendraDani, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot temporarily deployed to Preview October 18, 2023 12:30 Inactive
src/components/Modal/Modal.jsx Outdated Show resolved Hide resolved
@tamalCodes tamalCodes added status: need changes 🚧 Changes have been requested for these PRs and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Oct 22, 2023
@tamalCodes tamalCodes mentioned this pull request Oct 22, 2023
3 tasks
@MahendraDani
Copy link
Contributor Author

Applied changes

  1. Added font-family Inter to headers and Poppins to normal text in modals.
  2. Removed irrelevant text from console, fixes Bug: irrelevant text in console #1141

Before

Screenshot (25)

After

Screenshot (24)

@tamalCodes If there are any other changes please let me know.

@tamalCodes tamalCodes linked an issue Oct 26, 2023 that may be closed by this pull request
3 tasks
src/components/Footer/Footer.css Outdated Show resolved Hide resolved
src/components/Footer/Footer.css Outdated Show resolved Hide resolved
src/components/Footer/Footer.css Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 51017c3
✅ Preview: https://milan-mtxogad83-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/89pGzEMd9FupNkqDEh47tNMcR5nc

View Workflow Logs

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🎉

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource 🚀.

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. and removed status: need changes 🚧 Changes have been requested for these PRs labels Oct 26, 2023
@tamalCodes tamalCodes merged commit d4a9644 into ngoworldcommunity:main Oct 26, 2023
4 checks passed
@MahendraDani
Copy link
Contributor Author

@tamalCodes Thanks for merging this pull request.
If any issues need addressing I am up for grabs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
Status: Merged/Discarded
Development

Successfully merging this pull request may close these issues.

Bug: irrelevant text in console Bug: contact us button is broken in footer
2 participants