Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added readme badges #737

Merged
merged 11 commits into from
May 27, 2023
Merged

docs: added readme badges #737

merged 11 commits into from
May 27, 2023

Conversation

S-ishita
Copy link
Contributor

Related Issue

Closes: #719

Describe the changes you've made ✍

added badges in readme

Screenshots (if any) πŸ“Έ

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @S-ishita, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot temporarily deployed to Preview May 23, 2023 13:27 Inactive
@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label May 23, 2023
@S-ishita S-ishita changed the title Update README.md [docs] added readme badges May 23, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @S-ishita please make the PR title in a conventional way :

image

@S-ishita S-ishita changed the title [docs] added readme badges docs: added readme badges May 23, 2023
@S-ishita
Copy link
Contributor Author

done @iamtamal

@tamalCodes tamalCodes added πŸ“š docs This issue is related to documentation fixes. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels May 23, 2023
@S-ishita
Copy link
Contributor Author

is it ok now? @iamtamal

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good.
Always test your changes by looking at the Preview

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@tamalCodes tamalCodes added 🟩 priority: low πŸ’‘ feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: need changes 🚧 Changes have been requested for these PRs and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels May 24, 2023
@tamalCodes
Copy link
Member

is it ok now? @iamtamal

Yes, always do conventional commits and PRs.
If you write such kind of commit messages, at your work or Internship - you even have the chance of getting fired haha.
image

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work,
This looks good to me, will be merged soon πŸŽ‰.

@tamalCodes tamalCodes added status: ready βœ… This PR has passed all the checks and is now ready to be merged. and removed status: need changes 🚧 Changes have been requested for these PRs labels May 27, 2023
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 2143849
βœ… Preview: https://milan-1za11fz9n-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/3nynAXTNRViE7EmVLdzvKtjZ4Fuq

View Workflow Logs

@tamalCodes tamalCodes merged commit 7afbbd1 into ngoworldcommunity:main May 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed This PR has been deployed to Vercel for testing. πŸ“š docs This issue is related to documentation fixes. πŸ’‘ feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: ready βœ… This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] add readme badges
2 participants