feat: added company name after logo image and hover effect in nav-links #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello, @Iamdivyak, thank you for opening a pull request.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.
Give us a ⭐ to show some support
Happy OpenSource 🚀
github-actions
bot
added
the
deployed
Iamdivyak
changed the title
Iamdivyak
changed the title
tamalCodes
requested changes
May 28, 2023
There was a problem hiding this comment.
Also for the parent anchor tag that includes the Image and span - can we perhaps use Link there ? We might also wanna add a flex based display because the image and the brand-name looks not aligned.
display: flex;
align-items: center;This can be added to the parent div in order to keep the image and brand-name in sync.
tamalCodes
added
area/ui
|
made required changes |
tamalCodes
requested changes
May 28, 2023
src/components/Navbar.jsx
Outdated
| <img | ||
| src={ | ||
| solidarity || | ||
| "https://www.shareicon.net/data/512x512/2016/09/15/829452_user_512x512.png" | ||
| } | ||
| alt="Milan-logo" | ||
| className="nav_bramhin_img" | ||
| /> | ||
| /> <span className="brand-name">MILAN</span> |
There was a problem hiding this comment.
And for this one, the classname can be nav_brand_name
|
done |
|
This pull request has been deployed to Vercel.
|
tamalCodes
approved these changes
May 29, 2023
tamalCodes
added
status: ready ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: added company name after the logo and hover effect in nav-links
Related Issue
Closes: #744
Changes made 👷🏻♂️
Screenshots 📸