Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes for grammatical and spelling errors #818

Merged
merged 11 commits into from
Jun 9, 2023

Conversation

HimanshuNarware
Copy link
Member

feat: grammatical and spelling errors were resolved from the website, It will improve the readability of the website as well as improve the user experience

Related Issue

Closes: #
#772

Changes made πŸ‘·πŸ»β€β™‚οΈ

resolved all grammatical and spelling errors present on the website and other files

@github-actions github-actions bot added πŸ’‘ feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 6, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @HimanshuNarware, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 6, 2023
@HimanshuNarware HimanshuNarware changed the title feat: grammatical and spelling errors were resolved feat:grammatical and spelling errors were resolved Jun 6, 2023
@HimanshuNarware HimanshuNarware changed the title feat:grammatical and spelling errors were resolved docs: grammatical and spelling errors were resolved Jun 6, 2023
@HimanshuNarware HimanshuNarware changed the title docs: grammatical and spelling errors were resolved feat : grammatical and spelling errors were resolved Jun 6, 2023
@HimanshuNarware HimanshuNarware changed the title feat : grammatical and spelling errors were resolved refactor: grammatical and spelling errors were resolved Jun 6, 2023
@HimanshuNarware HimanshuNarware changed the title refactor: grammatical and spelling errors were resolved style: grammatical and spelling errors were resolved Jun 6, 2023
@tamalCodes tamalCodes changed the title style: grammatical and spelling errors were resolved fix: changes for grammatical and spelling errors Jun 6, 2023
@tamalCodes tamalCodes added 🐞 bug This is a patch, generally fixing some bugs. πŸ“ˆ Major This a breaking change as it changes different files, and dependencies. and removed πŸ’‘ feature This generally contains addition/changes to features. labels Jun 6, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, please donot make any changes to this file, as we are working on it.

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the following changes done, we can get this merge. Please always checkout for duplicates, and unwanted spaces.

rules/FrontendSetup.md Outdated Show resolved Hide resolved
src/components/Events/index.jsx Outdated Show resolved Hide resolved
src/components/Events/index.jsx Show resolved Hide resolved
src/pages/Donate.jsx Outdated Show resolved Hide resolved
src/pages/shops/ShopCategory.jsx Outdated Show resolved Hide resolved
@tamalCodes tamalCodes added πŸ“š docs This issue is related to documentation fixes. 🟨 priority: medium status: need changes 🚧 Changes have been requested for these PRs gssoc23 This issue/PR is part of GSSOC'23. level2 GSSOC 23 -> LEVEL 2 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 7, 2023
@HimanshuNarware
Copy link
Member Author

I have made all changes in my code as you said, but what about the code of conduct you said that dont make any changes in this file

@tamalCodes
Copy link
Member

Hi @HimanshuNarware , yes we don't want any changes now to the Code of Conduct file which you added. It would be better to remove this .

image

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the changes looks good to me, with the below mentioned changes done we can finally merge it !

public/CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@HimanshuNarware
Copy link
Member Author

HimanshuNarware commented Jun 9, 2023

CODE_OF_CONDUCT REMOVED @tamalCodes

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This pull request has been deployed to Vercel.

Latest commit: 4fda04e
βœ… Preview: https://milan-hw239rby5-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/C1We9knWgiFpThsvP7YUDH95kVD8

View Workflow Logs

@tamalCodes tamalCodes merged commit d02829c into ngoworldcommunity:main Jun 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. deployed This PR has been deployed to Vercel for testing. πŸ“š docs This issue is related to documentation fixes. gssoc23 This issue/PR is part of GSSOC'23. level2 GSSOC 23 -> LEVEL 2 πŸ“ˆ Major This a breaking change as it changes different files, and dependencies. status: need changes 🚧 Changes have been requested for these PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants