Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve accessibility of social anchors on footer #820

Merged
merged 2 commits into from
Jun 6, 2023
Merged

feat: improve accessibility of social anchors on footer #820

merged 2 commits into from
Jun 6, 2023

Conversation

0xabdulkhalid
Copy link
Contributor

Related Issue

Closes: #792

Changes made πŸ‘·πŸ»β€β™‚οΈ

  • Added aria-label attribute for social anchors like github & twitter
  • The aria-label attribute is important for screen readers because it provides a text label for an object, such as a with social icons. When a screen reader encounters the object, the aria-label text is read so that the user will know what it is.
  • This is important for people who are blind or have low vision, as they rely on screen readers to access the web.
  • Added title attribute, because the title attribute is intended to provide additional information to screen reader users.
  • And along with that i added rel for the anchors which are lacking them to ensure best practices for crawlers
  • Because adding the rel="noopener noreferrer" attribute can help to protect this website from security vulnerabilities and improve performance. It is a good practice to use this attribute on all external links.
  • Overall this PR is intended to make necessary changes to meet best practices for crawlers along with improving accessibility for social anchors

Screenshots πŸ“Έ

  • We can't take screenshots of accessibility changes rather than code changes, Accessibility changes are often invisible to the user because it's intended to guide disabled people

@github-actions github-actions bot added πŸ’‘ feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 6, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @0xabdulkhalid, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot temporarily deployed to Preview June 6, 2023 13:06 Inactive
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

This pull request has been deployed to Vercel.

Latest commit: ca73297
βœ… Preview: https://milan-802k76g8w-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/7tCfwk1uUxe1MHpwQiQMt7SpjfBf

View Workflow Logs

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 6, 2023
@tamalCodes tamalCodes added 🟧 priority: high area/accessibility This issue is related to an accessiblity fix. gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 6, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work,

This looks good to me, will be merged soon πŸŽ‰.
You can also visit the other components and help improve their accessibility, so that the site is accessible properly, following all the latest standards.

@tamalCodes tamalCodes added the status: ready βœ… This PR has passed all the checks and is now ready to be merged. label Jun 6, 2023
@tamalCodes tamalCodes merged commit bb8e241 into ngoworldcommunity:main Jun 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility This issue is related to an accessiblity fix. deployed This PR has been deployed to Vercel for testing. πŸ’‘ feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 status: ready βœ… This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: ACCESSIBLE SOCIAL ANCHORS ON FOOTER
2 participants