Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FormatPrice component #826

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

Nitish-hack
Copy link
Contributor

Related Issue

Closes: #766

Changes made πŸ‘·πŸ»β€β™‚οΈ

I have created a folder named Helper in src , and in that a file named FormatPrice.jsx, and i have also done changes in Product card

Screenshots πŸ“Έ

image

@github-actions github-actions bot added πŸ’‘ feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 7, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Nitish-hack, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot temporarily deployed to Preview June 7, 2023 15:59 Inactive
@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 7, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good !

@tamalCodes tamalCodes added area/logic This issue is related to a logic fix. 🟨 priority: medium status: need changes 🚧 Changes have been requested for these PRs gssoc23 This issue/PR is part of GSSOC'23. level2 GSSOC 23 -> LEVEL 2 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 9, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work,
This looks good to me, will be merged soon πŸŽ‰.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This pull request has been deployed to Vercel.

Latest commit: ab81f11
βœ… Preview: https://milan-f8veydud2-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/3YbvAReLMMh62vXKixwWpx7F9abS

View Workflow Logs

@tamalCodes tamalCodes merged commit a0f850a into ngoworldcommunity:main Jun 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. deployed This PR has been deployed to Vercel for testing. πŸ’‘ feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level2 GSSOC 23 -> LEVEL 2 status: need changes 🚧 Changes have been requested for these PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Thinking to create a Format Price component in react
2 participants