Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add address-autocomplete feature #831

Merged
merged 7 commits into from
Jun 13, 2023
Merged

feat: add address-autocomplete feature #831

merged 7 commits into from
Jun 13, 2023

Conversation

suzy-g38
Copy link
Contributor

@suzy-g38 suzy-g38 commented Jun 8, 2023 •
edited
Loading

Related Issue

Closes: #811

Changes made 👷🏻‍♂️

Added Geoapify API to do the autocomplete search places.
Also changed the color of the form's header and button.
This is the product that I have used.
https://www.geoapify.com/address-autocomplete

Currently, I have given the API key for the autocomplete component in the env.example. But we can also tell the contributors to use their own API key to prevent the API usage limit. Currently, it is in the free tier.

Screenshots 📸

Milan-AutoComplete-Address.mp4

@github-actions github-actions bot added 💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 8, 2023
github-actions[bot]
github-actions bot reviewed Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @suzy-g38, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 8, 2023
@tamalCodes tamalCodes added the 📈 Major This a breaking change as it changes different files, and dependencies. label Jun 9, 2023
tamalCodes
tamalCodes requested changes Jun 10, 2023
View reviewed changes
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would it be possible to just showcase how the autocomplete works, especially for the events part? Any tool like Loom, or OBS would be enough for the purpose.

I guess an auto-complete feature would be also added to User and Club registration too if it looks and works well. The code looks fine to me, except the below mentioned changes.

src/pages/clubs/EventCreate.jsx Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
@tamalCodes tamalCodes added status: conflicts ⛔ This PR has some conflicting files which needs to be resolved before further development. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 10, 2023
@suzy-g38
Copy link
Contributor Author

Also would it be possible to just showcase how the autocomplete works, especially for the events part? Any tool like Loom, or OBS would be enough for the purpose.

I guess an auto-complete feature would be also added to User and Club registration too if it looks and works well. The code looks fine to me, except the below mentioned changes.

Yeah, my bad that I forgot to attach it...give me some time I will attach a video file there..actually local step takes a little time that's why. And the rest I will do the needful.

suzy-g38
suzy-g38 commented Jun 11, 2023
View reviewed changes
Copy link
Contributor Author

@suzy-g38 suzy-g38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished all the changes that were asked for.

@tamalCodes
Copy link
Member

Finished all the changes that were asked for.

Awesome. Do add a video whenever you get time - and don't forget to click on the resolve conversation button after you have fixed any requested changes. That helps us be on the same page.

suzy-g38
suzy-g38 commented Jun 11, 2023
View reviewed changes
Copy link
Contributor Author

@suzy-g38 suzy-g38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete yarn.lock

@suzy-g38
Copy link
Contributor Author

@tamalCodes I have made all the changes that you asked for and also attached the video file.

@suzy-g38
Copy link
Contributor Author

Finished all the changes that were asked for.

Awesome. Do add a video whenever you get time - and don't forget to click on the resolve conversation button after you have fixed any requested changes. That helps us be on the same page.

I have added the video.

@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 69728ad
✅ Preview: https://milan-pkv21dlsc-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/3tvzJXfu5Ree1n6SAFxfXQenyuJ4

View Workflow Logs

tamalCodes
tamalCodes approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work,
This looks good to me, will be merged soon 🎉.

I guess we do not have any free API which can be much more accurate, I will test this out locally too - merging will take some time as I need to add ENV vars to the production pipeline. Amazing work !

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. 🟨 priority: medium gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 and removed status: conflicts ⛔ This PR has some conflicting files which needs to be resolved before further development. 📈 Major This a breaking change as it changes different files, and dependencies. labels Jun 12, 2023
@suzy-g38
Copy link
Contributor Author

suzy-g38 commented Jun 13, 2023 •
edited
Loading

Amazing work, This looks good to me, will be merged soon 🎉.

I guess we do not have any free API which can be much more accurate, I will test this out locally too - merging will take some time as I need to add ENV vars to the production pipeline. Amazing work !

This one is free of cost to some extent...so yeah almost free and we can use that in our favour. Do let me know if you need anything else when you test them in your local. and thanks.

@tamalCodes tamalCodes merged commit c455221 into ngoworldcommunity:main Jun 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@tamalCodes tamalCodes tamalCodes approved these changes

Assignees

@suzy-g38 suzy-g38

Labels
deployed This PR has been deployed to Vercel for testing. 💡 feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Recreate form for Events
2 participants
@suzy-g38 @tamalCodes