Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved clubs heading responsiveness issue #832

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

Chirayu31
Copy link
Contributor

Related Issue

Closes: #793

Changes made πŸ‘·πŸ»β€β™‚οΈ

I have addressed the issue of clubs heading responsiveness, ensuring that it displays correctly on various screen sizes. The changes include updates to the CSS styles for the .cp_header1 class, utilizing media queries to adjust the font size and line height accordingly. This improvement ensures that the heading remains legible and properly aligned, providing a better user experience across different devices.

Screenshots πŸ“Έ

After Images:
Screenshot 2023-06-09 133218
Screenshot 2023-06-09 133305

Before Images can be seen in #793 Issue

@github-actions github-actions bot added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Jun 9, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Chirayu31, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 9, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, below are the side-by-side comparisons. To the left are the original/current ones and to the right are the changes.

I think the font size for mobiles can be increased, maybe they can have something in the range of 40 - 45 pixels. As the headings are looking too small.

Screenshots

Screenshot_5
Screenshot_6
Screenshot_7

@tamalCodes tamalCodes added 🟨 priority: medium status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. area/accessibility This issue is related to an accessiblity fix. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: need changes 🚧 Changes have been requested for these PRs and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 12, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work !

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource πŸš€.

@tamalCodes tamalCodes added status: ready βœ… This PR has passed all the checks and is now ready to be merged. and removed status: need changes 🚧 Changes have been requested for these PRs status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. labels Jun 15, 2023
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 4d64946
βœ… Preview: https://milan-f1dwu4osv-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/J5r4RUMbNYagkWqNKmfgznTnQjbT

View Workflow Logs

@tamalCodes tamalCodes merged commit 9f1ff72 into ngoworldcommunity:main Jun 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility This issue is related to an accessiblity fix. 🐞 bug This is a patch, generally fixing some bugs. deployed This PR has been deployed to Vercel for testing. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: ready βœ… This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix responsiveness issue with clubs page heading
2 participants