Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added hover state on navbar #836

Merged
merged 5 commits into from
Jun 14, 2023
Merged

feat: added hover state on navbar #836

merged 5 commits into from
Jun 14, 2023

Conversation

Souravvmishra
Copy link
Contributor

Related Issue

Closes: #734

Changes made 👷🏻‍♂️

Added hover state on the link items in the navbar.

Screenshots 📸

github-actions[bot]
github-actions bot reviewed Jun 10, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Souravvmishra, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot temporarily deployed to Preview June 10, 2023 02:49 Inactive
@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 10, 2023
@tamalCodes tamalCodes changed the title style: added hover state on navbar feat: added hover state on navbar Jun 10, 2023
@tamalCodes tamalCodes added 💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 10, 2023
tamalCodes
tamalCodes requested changes Jun 10, 2023
View reviewed changes
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, do add a transition so that the animation of hovering in and hovering out is smooth. Currently, it feels pretty bad to Hover.

@tamalCodes tamalCodes added area/ui This issue is related to frontend/interface fix. 🟩 priority: low status: need changes 🚧 Changes have been requested for these PRs gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 10, 2023
@Souravvmishra
Copy link
Contributor Author

@tamalCodes I have added the required transition. PLease Check

tamalCodes
tamalCodes approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@tamalCodes tamalCodes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work !

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also shoutouts on social media (LinkedIn and Twitter) !

Happy Opensource 🚀.

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. and removed status: need changes 🚧 Changes have been requested for these PRs labels Jun 12, 2023
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 1e18d5e
✅ Preview: https://milan-kptk31dlb-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/hf76rRzyDeZrjrvDmcJ4E8y8yA5t

View Workflow Logs

@tamalCodes tamalCodes merged commit b362d19 into ngoworldcommunity:main Jun 14, 2023
4 checks passed
@Souravvmishra
Copy link
Contributor Author

This PR has not been considered in the gssoc2023. Can someone Check & let me know where I went wrong.

@tamalCodes
Copy link
Member

This PR has not been considered in the gssoc2023. Can someone Check & let me know where I went wrong.

Hi, we are looking into it - please wait !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@tamalCodes tamalCodes tamalCodes approved these changes

Assignees

@Souravvmishra Souravvmishra

Labels
area/ui This issue is related to frontend/interface fix. deployed This PR has been deployed to Vercel for testing. 💡 feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Hover State On Navbar Links
2 participants
@Souravvmishra @tamalCodes