Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing.md): upgrades to contributing file #838

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

rahulaarora
Copy link
Member

Related Issue

Closes: #824

Changes made πŸ‘·πŸ»β€β™‚οΈ

Fixed typographical and grammatical errors in CONTRIBUTING.md

@github-actions github-actions bot added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. πŸ“š docs This issue is related to documentation fixes. labels Jun 10, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @rahulaarora, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 10, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with these changes done, we can go ahead and merge it !

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@tamalCodes tamalCodes added 🐞 bug This is a patch, generally fixing some bugs. 🟨 priority: medium status: need changes 🚧 Changes have been requested for these PRs gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 10, 2023
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 7617369
βœ… Preview: https://milan-4ojcpawkh-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/HWeUEkjKtVHGZV1upwaiPhj2sAh7

View Workflow Logs

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work,
This looks good to me, will be merged soon πŸŽ‰.

@tamalCodes tamalCodes added status: ready βœ… This PR has passed all the checks and is now ready to be merged. and removed status: need changes 🚧 Changes have been requested for these PRs labels Jun 11, 2023
@tamalCodes tamalCodes merged commit e258539 into ngoworldcommunity:main Jun 12, 2023
4 checks passed
@rahulaarora rahulaarora deleted the rahulaarora/issue824 branch June 12, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. deployed This PR has been deployed to Vercel for testing. πŸ“š docs This issue is related to documentation fixes. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: ready βœ… This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] fix typo in CONTRIBUTING.md
2 participants