Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: meta tags added #859

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Conversation

Avinash905
Copy link
Contributor

Related Issue

Closes: #855

Changes made πŸ‘·πŸ»β€β™‚οΈ

Added primary meta tags, og tags, and twitter tags.

@github-actions github-actions bot added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Jun 16, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Avinash905, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot temporarily deployed to Preview June 16, 2023 22:39 Inactive
@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 16, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the preview for Twitter is not loading. I was using the social share preview extension, but there's no Twitter card showing up. Please look into it.

image

@tamalCodes tamalCodes added status: need changes 🚧 Changes have been requested for these PRs area/accessibility This issue is related to an accessiblity fix. gssoc23 This issue/PR is part of GSSOC'23. level2 GSSOC 23 -> LEVEL 2 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 20, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work !

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource πŸš€.

@tamalCodes tamalCodes added status: ready βœ… This PR has passed all the checks and is now ready to be merged. and removed status: need changes 🚧 Changes have been requested for these PRs labels Jun 22, 2023
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 33dd625
βœ… Preview: https://milan-hny4aaj28-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/2qBPn9T9SMn4Y6FMpfmsSPXCQBnT

View Workflow Logs

@tamalCodes tamalCodes merged commit 484d9d3 into ngoworldcommunity:main Jun 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility This issue is related to an accessiblity fix. 🐞 bug This is a patch, generally fixing some bugs. deployed This PR has been deployed to Vercel for testing. gssoc23 This issue/PR is part of GSSOC'23. level2 GSSOC 23 -> LEVEL 2 status: ready βœ… This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding proper meta tags to the website
2 participants